Skip to content

chore: bump NosCore.Packets to 17.0.0#7

Merged
erwan-joly merged 1 commit intomasterfrom
chore/bump-packets-17
Apr 24, 2026
Merged

chore: bump NosCore.Packets to 17.0.0#7
erwan-joly merged 1 commit intomasterfrom
chore/bump-packets-17

Conversation

@erwan-joly
Copy link
Copy Markdown
Contributor

@erwan-joly erwan-joly commented Apr 24, 2026 •
edited by coderabbitai Bot
Loading

Picks up NosCoreIO/NosCore.Packets#446 — deserializer fix for empty SpecialSeparator and CModePacket.MorphSkin widening.

Summary by CodeRabbit

  • Chores
    • Updated core system dependency to version 17.0.0 with latest improvements.

@erwan-joly @claude
chore: bump NosCore.Packets to 17.0.0
742b21a 
Picks up the deserializer fix for empty SpecialSeparator (fixes every
equip / eq / in / NsTeST packet with an UpgradeRareSubPacket field) and
the CModePacket.MorphSkin byte→short widening.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f7da098-f9b8-4ed0-b6cd-f2e017d70d3e

📥 Commits

Reviewing files that changed from the base of the PR and between ec4b843 and 742b21a.

📒 Files selected for processing (1)
  • Directory.Packages.props
📝 Walkthrough

Walkthrough

The NosCore.Packets NuGet package dependency was updated from version 16.9.0 to 17.0.0 in the centrally managed package configuration file.

Changes

Cohort / File(s) Summary
Dependency Version Update
Directory.Packages.props		 Bumped NosCore.Packets package version from 16.9.0 to 17.0.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A version hops along with grace,
From 16.9.0 to 17.0's pace,
Packets flow like carrots fresh and new,
One line changed, dependencies renewed! 🥕✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: bumping the NosCore.Packets package version to 17.0.0, which is the sole modification in this changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-packets-17

Comment @coderabbitai help to get the list of available commands and usage tips.

@erwan-joly erwan-joly merged commit 218c0f1 into master Apr 24, 2026
3 checks passed
@erwan-joly erwan-joly deleted the chore/bump-packets-17 branch April 24, 2026 08:12
This was referenced Apr 24, 2026
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@erwan-joly